HELP!!!what's wrong with my programme

littleguy

my english is vary bad. if there is any grammatical mistake, i'm sorry about that.

this programme is for generate a solution simply

#include <iostream>
#include <stdlib>
#include <time>

int temp[9][9],q=0, a=0, i=0,j=0,k=0,l=0,m=0, n=0, o=0,p=0, r=0, chance=0,chancer=0,chancec=0,chanceq=0, c1c=0,c1r=0,c1qi=0,c1qj=0;
char QUE[9][9];
bool crow[9][9],ccol[9][9],cq[9][9];

void checking(int i, int j, int n, int *chance) {
if (temp[i][j]==n)
*chance++; }

void checkingQ(int q, int n) {
int i=0,j=0;
switch (q) {
case 0 : o=0;
p=0;
break;
case 1 : o=0;
p=3;
break;
case 2 : o=0;
p=6;
break;
case 3 : o=3;
p=0;
break;
case 4 : o=3;
p=3;
break;
case 5 : o=3;
p=6;
break;
case 6 : o=6;
p=0;
break;
case 7 : o=6;
p=3;
break;
case 8 : o=6;
p=6;
break; }
for (i=o; i<(o+3); i++)
for (j=p; j<(p+3); j++) {
if (temp[i][j]==n) {
chanceq++;
c1qi=o;
c1qj=p; } } }

int main()
{ time_t rawtime;

for (i=0; i<9; i++)
for (j=0; j<9; j++) {
crow[i][j]=ccol[i][j]=cq[i][j]=false; temp[i][j]=0; }

for (a=0; a<40; a++) {
k=0; l=0;
for (q=0; q<9; q++) {
for (i=k; i<(k+3); i++)
for (j=l; j<(l+3); j++) {
rerand :
srand(time(NULL)+r++);
n=rand()%9;
cout << n << endl;
if (temp[i][j] == 0) {
if (crow[i][n]==false && ccol[n][j]==false && cq[q][n]==false) {
temp[i][j]=n;
crow[i][n]=true;
ccol[n][j]=true;
cq[q][n]=true; } } }
if (l+3<9)
l+=3;
else {
k+=3;
l=0; } } }

cout << '\n';
for (i=0; i<9; i++) {
for (j=0; j<9; j++)
cout << temp[i][j] << ' ';
cout << '\n'; }

k=0; l=0;
for (q=0; q<9; q++) {
for (i=k; i<(k+3); i++)
for (j=l; j<(l+3); j++) {

if (temp[i][j] == 0) {

for (o=0; o<9; o++) { <~I found that the problem may started at here, but i don't know what the problem is Sad

for (m=0; m<9; m++) {
checking(m,j,o,&chancec);
if (chancec==1)
c1c=o;
checking(i,m,o,&chancer);
if (chancer==1)
c1r=o; }
checkingQ(q,o); }

if (chancec==1) {
for (m=0; m<9>0)
temp[i][m]=0; }
checkingQ(q,c1c);
if (chanceq>0)
temp[o][p]=0;
temp[i][j]=c1c; }
if (chancer==1) {
for (m=0; m<9>0)
temp[m][j]=0; }
checkingQ(q,c1r);
if (chanceq>0)
temp[o][p]=0;
temp[i][j]=c1r; } } }

if (l+3<9)
l+=3;
else {
k+=3;
l=0; } }

cout << '\n';
for (i=0; i<9; i++) {
for (j=0; j<9; j++)
cout << temp[i][j] << ' ';
cout << '\n'; }

system("PAUSE");
return 0;
}

humble_programmer · Posted: Sat Jan 20, 2007 2:38 pm Post subject:

Here are some things to look into:

(1) You are using the variables chancec, chancer, and chanceq as flags, but you don't appear to ever reset them back to zero. Once they're set, they stay set for the rest of the program...not a very effective flag!

(2) You've got some syntax errors in later for() loops, but I'll assume that occured in the copy/paste process.

(3) I would recommend that you avoid using the letter 'o' as a variable name, 'cause it is easily confused with zero and makes your code harder to read.
_________________
Cheers!
Humble Programmer
,,,^..^,,,
www.humble-programmer.com

littleguy · Posted: Sun Jan 21, 2007 6:29 am Post subject:

humble_programmer · Posted: Sun Jan 21, 2007 2:26 pm Post subject:

The wonky for() loop was this one:

littleguy · Posted: Mon Jan 22, 2007 11:19 am Post subject:

thank you for your suggestion.

i had improved my programme. could you tell me is there any logic error?

littleguy · Posted: Tue Jan 23, 2007 3:42 pm Post subject:

i found that the above programme can't stop after it run.
There must be some problem. Could you tell me?

I also want to know is there any possible way to create a solution.
Please express it in a way that is easy to understand.
Thank you very much Smile